Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rate limiter #894

Closed

Conversation

YarekTyshchenko
Copy link

@YarekTyshchenko YarekTyshchenko commented Oct 15, 2021

The issue or feature being addressed

This PR is a resurrection of #666 only because the author seems to be unreachable. Most of the work has already been done by @reisenberger

Solves Issue #260

Details on the issue fix or feature implementation

Confirm the following

  • I started this PR by branching from the head of the latest dev vX.Y branch, or I have rebased on the latest dev vX.Y branch, or I have merged the latest changes from the dev vX.Y branch
  • I have targeted the PR to merge into the latest dev vX.Y branch as the base branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@dnfadmin
Copy link

dnfadmin commented Oct 15, 2021

CLA assistant check
All CLA requirements met.

@YarekTyshchenko YarekTyshchenko changed the base branch from master to v723-or-v730 October 15, 2021 10:10
@derigel23
Copy link

Any progress on accepting & merging this PR?

@martincostello
Copy link
Member

martincostello commented Dec 2, 2021

I'm planning on reviving the other original PR imminently, but with some additional changes on top based on some minor tweaks we made in a private fork we've been running in production for the last 18 months.

@martincostello
Copy link
Member

Thank you for trying to resurrect #666 via this PR @YarekTyshchenko.

As this has been in draft for a while now I'm going to close this.

I've created a new PR with the aim to get the rate limiting policy merged here - #903.

Please address any comments on the functionality there.

@YarekTyshchenko YarekTyshchenko deleted the RateLimiter branch December 8, 2021 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants